Minor fixes to make SLES work again #1390

trevor-vaughan · 2017-05-14T03:30:06Z

Pull the updated RPM GPG key
Remove rubygem-puppet prior to trying to install puppet-agent
Tested with opensuse/openSUSE-42.2-x86_64

puppetlabs-jenkins · 2017-05-14T03:50:20Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3812/

trevor-vaughan · 2017-05-15T00:05:46Z

@puppetlabs/beaker Can someone clue me in as to why Jenkins is mad? All of the tests ran fine on my system.

tvpartytonight · 2017-05-15T17:19:39Z

@trevor-vaughan here is the relevant error message from Jenkins, from the test check_for_package:

(sles12-64-1) 20:41:04$ zypper --gpg-auto-import-keys se -i --match-exact non-existent-package-name
      File 'repomd.xml' from repository 'pl-puppetserver-latest' is signed with an unknown key 'B8F999C007BB6C57'. Continue? [yes/no] (no):       Cannot read input: bad stream or EOF.
      If you run zypper without a terminal, use '--non-interactive' global
      option to make zypper use default answers to prompts.
      Error building the cache:
      [pl-puppetserver-latest|http://nightlies.puppetlabs.com/puppetserver-latest/repos/sles/12/PC1/x86_64/] Valid metadata not found at specified URL
      Warning: Skipping repository 'pl-puppetserver-latest' because of the above error.

I am a bit surprised that the tests passed with your opensuse system; I would have thought that the you would have run into the same error the jenkins testing encountered above ^^.

Looping in @shrug : the resource at yum.puppetlabs.com, could that be updated to mirror the nightlies resource?

trevor-vaughan · 2017-05-15T17:49:05Z

@tvpartytonight Actually, it makes complete sense.

You're signing things with two different keys and you have to pick one.

Jenkins wants your special sauce, not on the Internet, key but I changed it to import the Internet key so that it would work with the publicly published packages.

https://github.com/puppetlabs/beaker/pull/1390/files#diff-bcaa88e697be9464be7e94c1c8a44fa7L35

* Pull the updated RPM GPG key * Remove rubygem-puppet prior to trying to install puppet-agent * Tested with opensuse/openSUSE-42.2-x86_64

trevor-vaughan · 2017-05-22T02:23:12Z

Rebased against the current HEAD

puppetlabs-jenkins · 2017-05-22T02:43:19Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3828/

trevor-vaughan · 2017-05-30T21:39:08Z

@shrug and @tvpartytonight any update on this? I'm not sure what the "correct" answer is for the keys.

puppetlabs-jenkins · 2017-06-06T01:11:58Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3863/

trevor-vaughan · 2017-06-11T21:52:35Z

@shrug and @tvpartytonight Need insight into the new Jenkins failure. If you could get Jenkins to output the errors to GitHub, that would be most helpful.

DavidS · 2017-06-16T15:15:58Z


  1) Unix::Pkg check_for_package checks correctly on sles
     Failure/Error: result = self.exec(Command.new(command, [], cmd_create_options), exec_opts)
     
       #<Beaker::Command (class)> received :new with unexpected arguments
         expected: (/^rpmkeys --import http.+RPM-GPG-KEY.+/, anything, anything)
              got: ("rpmkeys --import http://nightlies.puppetlabs.com/07BB6C57", [], {:prepend_cmds=>nil, :cmdexe=>false})
       Diff:
       @@ -1,2 +1,4 @@
       -[/^rpmkeys --import http.+RPM-GPG-KEY.+/, "anything", "anything"]
       +["rpmkeys --import http://nightlies.puppetlabs.com/07BB6C57",
       + [],
       + {:prepend_cmds=>nil, :cmdexe=>false}]
       
     # ./lib/beaker/command_factory.rb:35:in `execute'
     # ./lib/beaker/host/unix/pkg.rb:35:in `check_for_package'
     # ./spec/beaker/host/unix/pkg_spec.rb:103:in `block (3 levels) in <module:Beaker>'

Finished in 20.63 seconds (files took 1.33 seconds to load)
1807 examples, 1 failure

Failed examples:

rspec ./spec/beaker/host/unix/pkg_spec.rb:97 # Unix::Pkg check_for_package checks correctly on sles

Build step 'Execute shell' marked build as failure
[BFA] Scanning build for known causes...
[BFA] No failure causes found
[BFA] Done. 0s
Finished: FAILURE

puppetlabs-jenkins · 2017-06-16T22:15:29Z

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3903/

DavidS · 2017-06-19T07:59:14Z

This has failed on a transient in our infrastructure. I've kicked the job, and opened QENG-5088 for tracking.

DavidS · 2017-06-19T16:13:00Z

PS: it seems like this has passed the jenkins now. cc @puppetlabs/beaker

tvpartytonight · 2017-06-19T16:49:31Z

The failure above is due to a Windows testing failure, not related to the changes in this PR.

@shrug , do you have any input here for the changes in this PR?

trevor-vaughan · 2017-07-01T21:01:52Z

@DavidS @tvpartytonight and @shrug I'm not sure what has been updated to conflict with foss_utils. I tried a quick rebase but it's a bit more complicated than I have time for right now.

trevor-vaughan · 2017-07-20T17:31:52Z

@DavidS @tvpartytonight and @shrug Do you have any ideas on what the issues are with the foss_utils files and how to fix them?

tvpartytonight · 2017-07-24T20:46:04Z

lib/beaker/dsl/install_utils/foss_utils.rb

@@ -367,6 +367,12 @@ def install_puppet_agent_on(hosts, opts = {})
            end

            if package_name
+              # Some SLES images already have rubygem-puppet installed and this


What SLES images are you dealing with that have rubygem-puppet installed? That sounds like that should be dealt with at an image level or within the pre-suite of your testing. I don't think that adding that here is the appropriate place for this logic.

@tvpartytonight I've been using the images directly from SuSE and OpenSuSE. If you take that out...you're gonna have a bad time....sometimes....

@tvpartytonight What I'm getting at is that the Beaker code itself calls that before I even get to my pre-suite anything from what I remember and that's a bit beyond the level of Beaker mangling that I'd like to do.

tvpartytonight · 2017-07-24T20:56:08Z

@trevor-vaughan we have done work to remove some of beaker's libraries into independent gems, and so the files conflicting now exist in this separate repo: https://github.com/puppetlabs/beaker-puppet. You'll need update your PR to resolve those conflicts or reopen the PR with only the changes necessary for your sles fixes. Apologies about letting this PR get a bit stale.

ferglor · 2017-07-31T16:42:42Z

last comment is still current

tvpartytonight · 2017-08-07T16:49:32Z

Last comment still current.

ferglor · 2017-08-14T16:29:54Z

Last comment still current. If no motion is made on this PR in another week, we’ll close this PR due to inactivity.

trevor-vaughan · 2017-08-14T16:53:20Z

@ferglor Last response is still current. Since Beaker significantly changed, I have not had time to figure out the new structure.

The option for maintainers to commit is open so feel free to update as necessary if you want SLES support in Beaker.

melissa · 2017-08-14T18:02:34Z

lib/beaker/host/unix/pkg.rb

@@ -33,6 +33,9 @@ def check_for_package(name, opts = {})
          # time. It's just to make sure that we only do the key import once, &
          # isn't for setting or use outside of beaker.
          execute('rpmkeys --import http://nightlies.puppetlabs.com/07BB6C57', opts)
+
+          # We also need the real key in case users are pulling from the stable packages
+          execute('rpmkeys --import https://yum.puppetlabs.com/RPM-GPG-KEY-puppet', opts)


I've recently started work to try to fix the sles repos

I've added #1449, which alone isn't going to fix this. But I'm also working on getting our repo automation updated so it signs the yum repos, and provides the gpg key in the repo. With that, zypper will automatically import the key in the repo if directed to do so. This opens us up to transients for network blips, but it's certainly better than what we have. However, this is also a perfectly reasonable solution to fix these failures. I'm wondering if this key is available under /etc/pki/rpm-gpg/RPM-GPG-KEY-puppet-PC1. It would only be dropped there by the puppetlabs-release package. I'm not sure if that's getting installed or not

kevpl · 2017-09-18T17:07:54Z

It looks like there have been a number of moves from code around this section in beaker, as well as work for keys & issues handled here in other PRs as well. Since that's the case & no movement has been made on this PR recently, I'll close this due to inactivity.

If you'd like to re-open this PR, please update it so that it's in a merge- & test-able state for review.

Minor fixes to make SLES work again

ac00b84

* Pull the updated RPM GPG key * Remove rubygem-puppet prior to trying to install puppet-agent * Tested with opensuse/openSUSE-42.2-x86_64

Why not both?!

9768797

Testing is good

f3daa4b

tvpartytonight reviewed Jul 24, 2017

View reviewed changes

melissa reviewed Aug 14, 2017

View reviewed changes

kevpl closed this Sep 18, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor fixes to make SLES work again #1390

Minor fixes to make SLES work again #1390

trevor-vaughan commented May 14, 2017

puppetlabs-jenkins commented May 14, 2017

trevor-vaughan commented May 15, 2017

tvpartytonight commented May 15, 2017

trevor-vaughan commented May 15, 2017 •

edited

trevor-vaughan commented May 22, 2017

puppetlabs-jenkins commented May 22, 2017

trevor-vaughan commented May 30, 2017

puppetlabs-jenkins commented Jun 6, 2017

trevor-vaughan commented Jun 11, 2017

DavidS commented Jun 16, 2017

puppetlabs-jenkins commented Jun 16, 2017

DavidS commented Jun 19, 2017

DavidS commented Jun 19, 2017

tvpartytonight commented Jun 19, 2017

trevor-vaughan commented Jul 1, 2017

trevor-vaughan commented Jul 20, 2017

tvpartytonight Jul 24, 2017

trevor-vaughan Jul 24, 2017

trevor-vaughan Jul 24, 2017

tvpartytonight commented Jul 24, 2017

ferglor commented Jul 31, 2017

tvpartytonight commented Aug 7, 2017

ferglor commented Aug 14, 2017

trevor-vaughan commented Aug 14, 2017

melissa Aug 14, 2017

kevpl commented Sep 18, 2017

Minor fixes to make SLES work again #1390

Minor fixes to make SLES work again #1390

Conversation

trevor-vaughan commented May 14, 2017

puppetlabs-jenkins commented May 14, 2017

trevor-vaughan commented May 15, 2017

tvpartytonight commented May 15, 2017

trevor-vaughan commented May 15, 2017 • edited

trevor-vaughan commented May 22, 2017

puppetlabs-jenkins commented May 22, 2017

trevor-vaughan commented May 30, 2017

puppetlabs-jenkins commented Jun 6, 2017

trevor-vaughan commented Jun 11, 2017

DavidS commented Jun 16, 2017

puppetlabs-jenkins commented Jun 16, 2017

DavidS commented Jun 19, 2017

DavidS commented Jun 19, 2017

tvpartytonight commented Jun 19, 2017

trevor-vaughan commented Jul 1, 2017

trevor-vaughan commented Jul 20, 2017

tvpartytonight Jul 24, 2017

Choose a reason for hiding this comment

trevor-vaughan Jul 24, 2017

Choose a reason for hiding this comment

trevor-vaughan Jul 24, 2017

Choose a reason for hiding this comment

tvpartytonight commented Jul 24, 2017

ferglor commented Jul 31, 2017

tvpartytonight commented Aug 7, 2017

ferglor commented Aug 14, 2017

trevor-vaughan commented Aug 14, 2017

melissa Aug 14, 2017

Choose a reason for hiding this comment

kevpl commented Sep 18, 2017

trevor-vaughan commented May 15, 2017 •

edited