This repository has been archived by the owner on Jan 5, 2021. It is now read-only.
update styles & modify html.erb to function with the new styles #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <span class="has-text-grey-light">/</span> | ||
| $<%= guest_beer.price %> | ||
|
|
||
| <!-- Wine & Cider List --> |
There was a problem hiding this comment.
This version of the application does have a data model for these items, though they are not exposed in ActiveAdmin yet. Not really sure if we should opt to include them in the view and ditch the "Guest Beers" object (already a misnomer).
| $<%= guest_beer.price %> | ||
|
|
||
| <!-- Wine & Cider List --> | ||
| <div id="wine-cider" class="beer"> |
There was a problem hiding this comment.
Tests will fail here as well, because it will see 12 .beer classes (11 from the fixtures, 1 here) instead of the expected 11.
| @@ -1,7 +1,7 @@ | |||
| <!DOCTYPE html> | |||
| <html> | |||
| <head> | |||
| <title>Beer List :: East Nashville Beer Works</title> | |||
| <title>ENBW Beer List</title> | |||
There was a problem hiding this comment.
Previous review omitted this comment:
This change will break the test suite, as seen here. We would likely want to update it accordingly.
|
We discussed this offline last night, and this good to merge for now. The outlined tasks can be addressed in future PRs. |
stephenyeargin
approved these changes
Jul 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated styles should be ready to merge into the master branch. Feel free to test on the styles-testing branch before you pull into the master. Let me know if I need to make any other changes.