Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user agent string #10

Merged
merged 1 commit into from Jan 25, 2021
Merged

Update user agent string #10

merged 1 commit into from Jan 25, 2021

Conversation

stephenyeargin
Copy link
Member

Related to websages/jarvis#22

@vinbarnes
Copy link

There we go. I tested both user-agent strings with curl. The new one eventually gets a 200 after a 302 whereas the current one returns a 400.
Thanks for tracking this down @stephenyeargin 💯

@stephenyeargin
Copy link
Member Author

stephenyeargin commented Jan 24, 2021

@jameswhite The README appears to be out of date on the deployment steps, or I completely screwed up how it's done. There's a stray .whiskey_disk_git_changes file, so perhaps it moved to that? Everything on freyr is owned by root.

Copy link

@vinbarnes vinbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@stephenyeargin
Copy link
Member Author

Side note: why bother checking the URL twice? Could we not let Tumble decide what to do with it?

@stephenyeargin stephenyeargin merged commit f681df2 into production Jan 25, 2021
@stephenyeargin stephenyeargin deleted the update-user-agent branch January 25, 2021 18:42
@jameswhite
Copy link
Contributor

Measure twice, link once. Duh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants